Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for partial genes prokka-1.12 #218

Open
jennahd opened this issue Feb 23, 2017 · 1 comment
Open

Added support for partial genes prokka-1.12 #218

jennahd opened this issue Feb 23, 2017 · 1 comment
Assignees
Milestone

Comments

@jennahd
Copy link

jennahd commented Feb 23, 2017

In Summary:

  • Prodigal can now be run without the -c option (closed ends) allowing for partial gene prediction.
  • Prodigal's gff output is now parsed with Bio::Tools:GFF, using the 'partial' tag of prodigal to find genes running off edges.
  • Bio::Location::Fuzzy is used to correctly set the start and end of CDSs. Also the frame and codon_start attributes were set.
  • Some tweaking was performed to correctly print the tbl file, think all possible cases are covered.
  • Added a new --partialgenes option to prokka.

We (@novigit and I) applied these changes made by @lguy for prokka version 1.11 (issue #37) to prokka version 1.12.

In addition we made one other fix and completed some tests:

  • For partial genes on contig edges, in some cases proteins were being called in the wrong frame, but gene translation for these cases works properly now.
  • Running with --partialgenes now gives the same ORF predictions as prodigal without -c (except for ORFs that overlap with tRNAs etc. or those otherwise removed by prokka).
  • Running without --partialgenes gives the same ORF predictions as prodigal with -c (except for the ORFs that overlap with tRNAs etc. or those otherwise removed by prokka), re. the same output as prokka 1.12 before these changes.
  • No frameshift issues with partial genes were noted when running with several different gcode's.
@jennahd jennahd changed the title Adding support for partial genes prokka-1.12 Added support for partial genes prokka-1.12 Feb 23, 2017
@tseemann tseemann self-assigned this Mar 5, 2017
@tseemann tseemann added this to the Prokka 1.13 milestone Mar 5, 2017
@TreeT2
Copy link

TreeT2 commented Jul 19, 2017

Hi All,

Is this available in v1.12 or will we have to wait till v1.13?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants