Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require semicolon for newick? #50

Open
hyanwong opened this issue Jan 24, 2023 · 2 comments
Open

Require semicolon for newick? #50

hyanwong opened this issue Jan 24, 2023 · 2 comments

Comments

@hyanwong
Copy link
Member

I just did this:

tsconvert.from_newick("../results/extstrain_ncov_gisaid_global_all-time_timetree-2021-05-09.nwk"

And it took me a while to realise that this was imported as a tree with one node called ../results/extstrain_ncov_gisaid_global_all-time_timetree-2021-05-09.nwk! Perhaps this is a good reason to require the semicolon at the end of the newick string?
@jeromekelleher
Copy link
Member

Pros and cons either direction I guess.

@benjeffery
Copy link
Member

We're using python-newick for parsing (currently...) so prob best to stick to their requirements? No point in failing lots of newicks in the wild for this as it is not a subtle failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjeffery @jeromekelleher @hyanwong