Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator terminates with zero exit code on error #689

Open
penberg opened this issue Jan 14, 2025 · 4 comments
Open

Simulator terminates with zero exit code on error #689

penberg opened this issue Jan 14, 2025 · 4 comments
Labels
bug Something isn't working simulator

Comments

@penberg
Copy link
Collaborator

penberg commented Jan 14, 2025

We should make the simulator terminate with non-zero exit code so that external scripts, for example, can detect when it finds a problem.

@alpaylan
Copy link
Contributor

alpaylan commented Jan 14, 2025

I'll implement this on top of the minimization PR #623

edit: I just saw @LtdJorge opened a PR to fix it, but I would suggest we still do it on top of #623 because otherwise I'll just have to patch it anyway because it's a merge conflict.

@LtdJorge
Copy link
Contributor

Don't worry, we can hold off my PR and I'll rebase it on top of yours. Or we can close it and you do your own version, whatever you prefer.

@alpaylan
Copy link
Contributor

Both works for me, I can merge yours on top of mine too, shouldn't be too much of a hassle.

@LtdJorge
Copy link
Contributor

LtdJorge commented Jan 14, 2025

Ok, I'll be tracking your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working simulator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants