Skip to content

Tokens not parsed #860

Answered by SiTaggart
tomtobac asked this question in General
Oct 16, 2020 · 2 comments · 3 replies
Discussion options

You must be logged in to vote

Yeah, OK I thought you might say something like Truncate.

It follows my initial hunch, which is we effectively highjack a few global HTML attributes such as width, height and size and convert them to styling props. This works really well on the Styling primitives.

For other components we either try and extend the typings of the closest related HTML element that is going to be rendered, or for some older components like Truncate which are just styled components, we get the typings from Emotion for the HTMl element. Which I believe is where the confusion starts raising its head.

For components where we extending the typings on the HTML element, we aren't removing the highjacked attributes. …

Replies: 2 comments 3 replies

Comment options

You must be logged in to vote
3 replies
@vankhoawin
Comment options

@SiTaggart
Comment options

@tomtobac
Comment options

Comment options

You must be logged in to vote
0 replies
Answer selected by SiTaggart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants