Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PrometheusReporter performance #93

Open
SokolAndrey opened this issue Feb 9, 2021 · 0 comments
Open

Improve PrometheusReporter performance #93

SokolAndrey opened this issue Feb 9, 2021 · 0 comments
Assignees
@SokolAndrey

Comments

@SokolAndrey
Copy link
Collaborator

PrometheusReporter#reportHistogramDurationSamples and PrometheusReporter#reportHistogramValueSamples scored pretty bad in terms of throughput (0.693 ± 0.102 ops/ms and 0.777 ± 0.120 ops/ms, respectively) comparing to other StatsReporter implementations (e.g. M3Reporter: 188.096 ± 7.091 ops/ms and 127.358 ± 27.740 ops/ms).

The poor performance caused by usage of Histogram#observe method in a cycle, which executes another for-cycle over all the histogram's buckets (see discussion in the PR for more details).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SokolAndrey SokolAndrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SokolAndrey