From 84f9787f76d83af19b28817f1dbd6158ecc351c0 Mon Sep 17 00:00:00 2001
From: dreamyuki <49896401+dreamyukii@users.noreply.github.com>
Date: Sun, 12 Jan 2025 14:32:53 +0700
Subject: [PATCH] fix: make aurora-groups.sh executable  (#102)

* fix: forgot to chmod +x aurora-groups.sh

* Update system_files/shared/usr/lib/systemd/system/aurora-groups.service

using full path for the script

Co-authored-by: Adam Fidel <ledif@users.noreply.github.com>

* fix: bash array iteration

---------

Co-authored-by: Adam Fidel <ledif@users.noreply.github.com>
---
 .../shared/usr/lib/systemd/system/aurora-groups.service   | 4 +++-
 system_files/shared/usr/libexec/aurora-groups.sh          | 8 +++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 system_files/shared/usr/libexec/aurora-groups.sh

diff --git a/system_files/shared/usr/lib/systemd/system/aurora-groups.service b/system_files/shared/usr/lib/systemd/system/aurora-groups.service
index dc027a9..2135e53 100644
--- a/system_files/shared/usr/lib/systemd/system/aurora-groups.service
+++ b/system_files/shared/usr/lib/systemd/system/aurora-groups.service
@@ -1,10 +1,12 @@
 [Unit]
 Description=Add plugdev groups
+
 [Service]
 Type=oneshot
-ExecStart=/usr/libexec/aurora-groups
+ExecStart=/usr/libexec/aurora-groups.sh
 Restart=on-failure
 RestartSec=30
 StartLimitInterval=0
+
 [Install]
 WantedBy=default.target
\ No newline at end of file
diff --git a/system_files/shared/usr/libexec/aurora-groups.sh b/system_files/shared/usr/libexec/aurora-groups.sh
old mode 100644
new mode 100755
index 5ab2c38..7cf18bd
--- a/system_files/shared/usr/libexec/aurora-groups.sh
+++ b/system_files/shared/usr/libexec/aurora-groups.sh
@@ -1,13 +1,16 @@
 #!/usr/bin/env bash
+
 # SCRIPT VERSION
 GROUP_SETUP_VER=1
 GROUP_SETUP_VER_FILE="/etc/ublue/aurora-groups"
 GROUP_SETUP_VER_RAN=$(cat "$GROUP_SETUP_VER_FILE")
+
 # Run script if updated
 if [[ -f $GROUP_SETUP_VER_FILE && "$GROUP_SETUP_VER" = "$GROUP_SETUP_VER_RAN" ]]; then
   echo "Group setup has already run. Exiting..."
   exit 0
 fi
+
 # Function to append a group entry to /etc/group
 append_group() {
   local group_name="$1"
@@ -16,13 +19,16 @@ append_group() {
     grep "^$group_name:" /usr/lib/group | tee -a /etc/group > /dev/null
   fi
 }
+
 # Setup Groups
 append_group plugdev
+
 wheelarray=($(getent group wheel | cut -d ":" -f 4 | tr  ',' '\n'))
-for user in $wheelarray
+for user in "${wheelarray[@]}"
 do
   usermod -aG plugdev $user
 done
+
 # Prevent future executions
 echo "Writing state file"
 echo "$GROUP_SETUP_VER" > "$GROUP_SETUP_VER_FILE"
\ No newline at end of file