Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are released for unsuccessful PR merges #99

Open
ledif opened this issue Jan 10, 2025 · 1 comment
Open

Images are released for unsuccessful PR merges #99

ledif opened this issue Jan 10, 2025 · 1 comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code

Comments

@ledif
Copy link
Collaborator

ledif commented Jan 10, 2025

When a PR is added to a merge queue, the "Build Stable Images" and "Build Latest Images" actions push the succesfully built images to GHCR. However, it's possible that some of the images in the workflow will fail to build, which automatically removes the PR from the merge queue. This leaves us in an inconsistent state where we have published images in the stable-daily or latest streams that contain changes that aren't actually commited to main.

This is what happened when #44 failed to merge, but a user reported that their system automatically pulled in changes from the PR (which have not landed in main).

References:

@ledif ledif added the bug Something isn't working label Jan 10, 2025
@dosubot dosubot bot added the github_actions Pull requests that update GitHub Actions code label Jan 10, 2025
@ledif ledif changed the title Images are released for unsuccesful PR merges Images are released for unsuccessful PR merges Jan 10, 2025
@ledif
Copy link
Collaborator Author

ledif commented Jan 10, 2025

This is an issue that is known by the Bluefin folks (thanks @m2Giles). Some current workarounds:

  • If the build failed because of skew, it's fine to just force merge the PR so that the changes land in main anyway
  • If we decide we don't want the merge to occur (for instance, if there's an actual problem with the changes), we can manually delete the tagged packages on GHCR

Both of these require manual intervention. Long term, we can consider modifying the workflow to execute a job on failure that automatically purges the tagged images on GHCR that were created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

1 participant