From 7f1a1d85d89f423edcef7c71775df3a8135e9242 Mon Sep 17 00:00:00 2001 From: rhaesung Date: Tue, 21 Jan 2025 22:43:50 +0000 Subject: [PATCH] update module_sf_noahmp_glacier.F90 and module_sf_noahmplsm.F90 according to review --- .../SFC_Models/Land/Noahmp/module_sf_noahmp_glacier.F90 | 2 ++ physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 | 8 +++----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/physics/SFC_Models/Land/Noahmp/module_sf_noahmp_glacier.F90 b/physics/SFC_Models/Land/Noahmp/module_sf_noahmp_glacier.F90 index fcbe40a70..3906a53d6 100644 --- a/physics/SFC_Models/Land/Noahmp/module_sf_noahmp_glacier.F90 +++ b/physics/SFC_Models/Land/Noahmp/module_sf_noahmp_glacier.F90 @@ -842,12 +842,14 @@ subroutine radiation_glacier (dt ,tg ,sneqvo ,sneqv ,cosz , & !in ! snow albedos: age even when sun is not present + if(cosz > 0) then if(opt_alb == 1) & call snowalb_bats_glacier (nband,cosz,fage,albsnd,albsni) if(opt_alb == 2) then call snowalb_class_glacier(nband,qsnow,dt,alb,albold,albsnd,albsni) albold = alb end if + end if ! zero summed solar fluxes diff --git a/physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 b/physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 index 7ab496ddc..80ffdf62c 100644 --- a/physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 +++ b/physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90 @@ -3024,7 +3024,7 @@ subroutine albedo (parameters,vegtyp ,ist ,ice ,nsoil , & !in call snow_age (parameters,dt,tg,sneqvo,sneqv,tauss,fage) - if(cosz <= 0) goto 100 + if(cosz <= 0) ! weight reflectance/transmittance by lai and sai @@ -3045,6 +3045,8 @@ subroutine albedo (parameters,vegtyp ,ist ,ice ,nsoil , & !in albold = alb end if +100 continue + ! ground surface albedo call groundalb (parameters,nsoil ,nband ,ice ,ist , & !in @@ -9143,10 +9145,6 @@ subroutine groundwater(parameters,nsnow ,nsoil ,dt ,sice ,zsoil , & !in ! recharge rate qin to groundwater -! ka = hk(iwt) -! harmonic average, c.he changed based on gy niu's update -! ka = 2.0*(hk(iwt)*parameters%dksat(iwt)*1.0e3) / (hk(iwt)+parameters%dksat(iwt)*1.0e3) -! tried one suggesteed by gy niu ka = 0.5*(hk(iwt)+parameters%dksat(iwt)*1.0e3) wh_zwt = - zwt * 1.e3 !(mm)