Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During AC charging lock is not operated correctly if it has no feedback #46

Open
jsphuebner opened this issue Nov 22, 2024 · 6 comments

Comments

@jsphuebner
Copy link
Collaborator

In the newly introduced StandAlone AC charge mode the lock misbehaves:

  • We do not get past
    if (Param::GetInt(Param::LockState) == LOCK_OPEN)//only trigger is lock is open
    because initial LockState is None not Open
  • when manipulating (see below) LockOpenThresh the lock closes but the lock motor keeps running, ignoring LockRunTime
  • When reverting LockOpenThresh the motor stops and charging starts

Parameters:

  • LockRunTime 1500
  • LockClosedThresh 100
  • LockOpenThresh 100

For getting the lock to close LockOpenThresh set to 4000. For stopping the lock motor LockOpenThresh reverted to 100

@Tom-evnut
Copy link
Contributor

Tom-evnut commented Nov 22, 2024

Would it be an idea to force the lock into a known state, open, upon power on?

Does the Lock Feedback not get reviewed and state updated when booting?

@jsphuebner
Copy link
Collaborator Author

Yes, something like that, at least when LockOpenThresh=LockClosedThresh i.e. no feedback

@Tom-evnut
Copy link
Contributor

Oh okay it is because you set things to not toggle. Yes do a forced drive to open. Then evaluate if it should be open or closed.

Does you lock not run with feedback? Is it a pure solenoid one?

@jsphuebner
Copy link
Collaborator Author

It's a customers. His lock sometimes gets stuck so he operates without feedback to at least be able to charge. At the moment of testing the feedback was also disconnected but will be reconnected. Still it should be able to operate even without feedback, just with LockRunTime

@Tom-evnut
Copy link
Contributor

Yes there should be a fall back if feedback is not used or missing. Should be an easy enough to implement, as it boots into lockstate none

@jsphuebner
Copy link
Collaborator Author

I have tested AC standalone mode with and without feedback and also Actuatortest. It works as expected. Only if CP PWM goes away stateC will stay active. Could be fixed but more of a cosmetic issue I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants