-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
During AC charging lock is not operated correctly if it has no feedback #46
Comments
Would it be an idea to force the lock into a known state, open, upon power on? Does the Lock Feedback not get reviewed and state updated when booting? |
Yes, something like that, at least when LockOpenThresh=LockClosedThresh i.e. no feedback |
Oh okay it is because you set things to not toggle. Yes do a forced drive to open. Then evaluate if it should be open or closed. Does you lock not run with feedback? Is it a pure solenoid one? |
It's a customers. His lock sometimes gets stuck so he operates without feedback to at least be able to charge. At the moment of testing the feedback was also disconnected but will be reconnected. Still it should be able to operate even without feedback, just with LockRunTime |
Yes there should be a fall back if feedback is not used or missing. Should be an easy enough to implement, as it boots into lockstate none |
I have tested AC standalone mode with and without feedback and also Actuatortest. It works as expected. Only if CP PWM goes away stateC will stay active. Could be fixed but more of a cosmetic issue I think |
In the newly introduced StandAlone AC charge mode the lock misbehaves:
ccs32clara/ccs/acOBC.cpp
Line 338 in 612437f
Parameters:
For getting the lock to close LockOpenThresh set to 4000. For stopping the lock motor LockOpenThresh reverted to 100
The text was updated successfully, but these errors were encountered: