Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Markdown message building #3

Open
ulfsauer0815 opened this issue Jan 23, 2017 · 1 comment
Open

Proper Markdown message building #3

ulfsauer0815 opened this issue Jan 23, 2017 · 1 comment

Comments

@ulfsauer0815
Copy link
Owner

Building markdown messages consists of a few convenience functions that simply concatenate strings in a very inefficient manner.
This can be improved (readability, performance etc.), maybe Blaze has some interesting ideas?

@ulfsauer0815
Copy link
Owner Author

It might be possible to make message shortening smarter if it can work on an AST - shortening only the displayed content without touching the markup if possible.
This way we would actually shorten the displayed content and not mangle the markup which leads to broken/no markup.

Not considering markup within the message yet, which would require parsing markdown and also make the shortening logic more complicated.

The content size can still not be calculated accurately, e.g. when images are embedded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant