You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been porting this package to v8 for internal use (there is a PR for that that has not been merged #38) and I'm currently working on a v9/10/11 port as well.
I understand that it might be hard to find time to look at issues and maintain this package but I also feel that this is the best "starting point" out there for an "opening hours package".
I see several issues with the current code base that I think we need to address:
Unneeded dependencies on utility-frameworks
Internal/private classes and methods which make code that use the models from the package hard (or impossible) to test.
Mixing concerns where the type for the Property Value Converter is also used for storage which just makes the code base a lot more complicated. I think that they should be separated into a DTO for storage and a model for the PVC.
I would be happy to share my work and potentially modernize the build but I don't want to prepare a PR that gets stuck for 2 years.
I find myself with three options:
I get commit access to this repo and to the NuGet-feed so we can collaborate to release new versions
I'll fork and rebrand the package and increase the confusion one more level with two different "Opening Hours"-packages
We do nothing and I'll keep my updates in our internal NuGet feed ( which would be a bad idea for the community =D )
The text was updated successfully, but these errors were encountered:
Hi guys!
I've been porting this package to v8 for internal use (there is a PR for that that has not been merged #38) and I'm currently working on a v9/10/11 port as well.
I understand that it might be hard to find time to look at issues and maintain this package but I also feel that this is the best "starting point" out there for an "opening hours package".
I see several issues with the current code base that I think we need to address:
I would be happy to share my work and potentially modernize the build but I don't want to prepare a PR that gets stuck for 2 years.
I find myself with three options:
The text was updated successfully, but these errors were encountered: