Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future for this package? #40

Open
enkelmedia opened this issue Jan 24, 2023 · 0 comments
Open

Future for this package? #40

enkelmedia opened this issue Jan 24, 2023 · 0 comments

Comments

@enkelmedia
Copy link

enkelmedia commented Jan 24, 2023

Hi guys!

I've been porting this package to v8 for internal use (there is a PR for that that has not been merged #38) and I'm currently working on a v9/10/11 port as well.

I understand that it might be hard to find time to look at issues and maintain this package but I also feel that this is the best "starting point" out there for an "opening hours package".

I see several issues with the current code base that I think we need to address:

  • Unneeded dependencies on utility-frameworks
  • Internal/private classes and methods which make code that use the models from the package hard (or impossible) to test.
  • Mixing concerns where the type for the Property Value Converter is also used for storage which just makes the code base a lot more complicated. I think that they should be separated into a DTO for storage and a model for the PVC.

I would be happy to share my work and potentially modernize the build but I don't want to prepare a PR that gets stuck for 2 years.

I find myself with three options:

  • I get commit access to this repo and to the NuGet-feed so we can collaborate to release new versions
  • I'll fork and rebrand the package and increase the confusion one more level with two different "Opening Hours"-packages
  • We do nothing and I'll keep my updates in our internal NuGet feed ( which would be a bad idea for the community =D )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant