Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the city rather than the IP address in the audit logs #2247

Open
3 tasks done
harshsbhat opened this issue Oct 7, 2024 · 6 comments
Open
3 tasks done

Display the city rather than the IP address in the audit logs #2247

harshsbhat opened this issue Oct 7, 2024 · 6 comments
Labels
Feature New feature or request Needs Approval Needs approval from Unkey Needs Refinement This issue is too vague and needs a clear path of action.

Comments

@harshsbhat
Copy link
Contributor

Preliminary Checks

Is your feature request related to a problem? Please describe.

Currently we display the IP address in the audit logs which looks something like this:

image

Describe the solution

But as the end user, I would be more interested in the city or a location which is humanly readable rather than something like IP address

Describe alternatives you have considered (if any)

No response

Additional context

No response

@harshsbhat harshsbhat added Feature New feature or request Needs Approval Needs approval from Unkey labels Oct 7, 2024
Copy link

linear bot commented Oct 7, 2024

@chronark
Copy link
Collaborator

chronark commented Oct 8, 2024

The new logs @ogzhanolguncu is working on may provide insights into that, but we'll have to discuss it
it's not trivial to turn an ip into more geo information

@ogzhanolguncu
Copy link
Contributor

@chronark
Copy link
Collaborator

chronark commented Oct 8, 2024

@ogzhanolguncu do you mean showing the isocodes like GB-SWK?

maybe yeah, we still gotta get that information though.
It's fairly easy to get on cloudflare, but as we're migrating our API over to aws, we need to figure out how to get that kind of data

@ogzhanolguncu
Copy link
Contributor

Okay, I see your point now. We can introduce 3rd party for the lookup, but that might be too costly on our end. We should definitely discuss 👍🏻

@chronark chronark added the Needs Refinement This issue is too vague and needs a clear path of action. label Oct 8, 2024
@mrjayantbokade
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Needs Approval Needs approval from Unkey Needs Refinement This issue is too vague and needs a clear path of action.
Projects
None yet
Development

No branches or pull requests

4 participants