Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating ratelimit in the new workspace shows it in the personal workspace too #2395

Open
3 tasks done
harshsbhat opened this issue Oct 13, 2024 · 7 comments
Open
3 tasks done
Assignees
Labels
Bug Something isn't working Needs Approval Needs approval from Unkey

Comments

@harshsbhat
Copy link
Contributor

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

After creating the new rate limit in your workspace ( not personal ). It is still visible in the personal workspace. But if you click on it that will just redirect you to 404.

https://www.loom.com/share/d34c1076ee524a1abeaaabb15306a398?sid=d301ee35-5022-4f77-a37e-9c60343d8171

Steps to Reproduce

  1. Shift to a non-personal workspace.
  2. Create a ratelimit
  3. Switch back to your personal workspace. You will still see the same ratelimit. But it will redirect to 404.

Expected behavior

Ideally it shouldn't be visible after switching workspaces

Other information

No response

Screenshots

No response

Version info

- OS:
- Node:
- npm:
@harshsbhat harshsbhat added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 13, 2024
@unrenamed
Copy link
Contributor

It seems that all previously loaded data remains cached unless the page is reloaded. After creating a new workspace, you can skip the optional "Choose your adventure" step. When you navigate to any page via the left side menu—such as APIs, Audit Logs, or Rate Limits—you will notice that all pages display data from the previously selected workspace.

@harshsbhat
Copy link
Contributor Author

@unrenamed but what's the solution? I don't think that it's the best experience to see this right?

@unrenamed
Copy link
Contributor

@harshsbhat I agree with you. This is definitely a bug and the root cause somewhere in the client code that automatically switches to the created workspace.

My message was that I can reproduce the issue on my side and it appears to occur not only with ratelimits but other pages as well.

@harshsbhat
Copy link
Contributor Author

ah got it. I thought I was not understanding something which was causing the issue. Thanks for clarification though

@unrenamed
Copy link
Contributor

P.S. I see the confusion. The issue you found and the one I faced with are a bit different, although something tells me they might be related and fixed together.

See the steps:

  1. Create a new workspace
  2. Skip the "Choose your adventure" step
  3. (The new workspace will be automatically selected)
  4. Now go to any page from the side menu (e.g. APIs or Ratelimits or Audit Logs)
  5. You will see the data from the previous workspace.

@chronark
Copy link
Collaborator

Yeah, this is related to how we currently switch workspaces using clerk, it'll be different soon.

Assigning @mcstepp to double check this is fixed in the new implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Approval Needs approval from Unkey
Projects
None yet
Development

No branches or pull requests

4 participants