Confusing attributes

[MartinZikmund]

What would you like to be added:

UnoIcon consists of Include and ForegroundFile - which together compose the icon. However, technically the Include is the "background" and the actual icon is the ForegroundFile - this is quite weird. In case of splash screen, the Include is the actual icon.

When the user, who is not familiar with it comes in, they will most likely replace icon.svg with their icon and run the app - which will cause it to be their icon in the background and uno logo in front of it...

I think it would be more meaningful if the Include were the actual icon and there was a BackgroundFile attribute instead. The files also should be named more clearly icon_background.svg and icon.svg.

Similarly, I feel that Color attribute could become BackgroundColor, as now its purpose is not clear.

Why is this needed:

Clearity.

[pedrojesus-work]

MSBuild properties have this limitation, where Items outside target should have one of those operations: Include, Update or Remove. With that we use the Include to specify the asset that will be used.

If the user gets confuse, it can look into docs where he/she can see all the properties that are available and its meaning.

[MartinZikmund]

In such case still it would probably feel more meaningful if the Include was the icon itself and there was a IconBackground attribute for its background for example. However, I understand this technically a breaking change...

[dansiegel]

Proposal:

• *LEGACY SUPPORT* When UnoIcon has both Include and ForegroundFile we will process this as we always have.

• When we have UnoIcon with no ForegroundFile we will treat this as the actual icon and use a transparent background if one is not provided.

• When we have a UnoIconBackground we will apply this as the background file to the UnoIcon. This should be optional as many times you really just want a color and the icon.
  NOTE: We would want this as a new Item rather than in an Attribute on the UnoIcon because this will help MSBuild better watch the file for changes. Currently this is problematic for Resizetizer because if you change the foreground file MSBuild has no way of knowing it changed.

As @MartinZikmund suggested we can add a BackgroundColor attribute which can set the Color property in the MSBuild task. This would not have any backwards compatibility issues so long as we set the Color from the BackgroundColor.

[MartinZikmund]

This set of changes sounds good to me 🚀 ! For the ForegroundScale I guess can then be "replaced" by Scale as well (as it will be on UnoIcon only anyway