Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StartStopEventWrapper for sensor events #19131

Closed
MartinZikmund opened this issue Dec 26, 2024 · 4 comments · Fixed by #19166
Closed

Use StartStopEventWrapper for sensor events #19131

MartinZikmund opened this issue Dec 26, 2024 · 4 comments · Fixed by #19166
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request

Comments

@MartinZikmund
Copy link
Member

What would you like to be added

Currently most sensors use a field + event combo to ensure the sensor tracking is started when the first subscriber is added and stopped when the last subscriber is removed. This logic is encapsulated in StartStopEventWrapper, so to simplify the codebase, it should be used instead.

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response
@MartinZikmund MartinZikmund added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Dec 26, 2024
@MartinZikmund MartinZikmund changed the title Use StartStopEventWrapper for sensors Use StartStopEventWrapper for sensor events Dec 26, 2024
@nickodei
Copy link
Contributor

nickodei commented Jan 5, 2025 •
edited
Loading

Hey, I would be down to implement this change.

Just to make sure. You mean the files under: Uno.netcoremobile -> Devices\Sensors ?

@MartinZikmund
Copy link
Member Author

@nickodei Yes, that is the case, but before embarking on this, please wait until #7137 is merged (should be anytime now)

@nickodei
Copy link
Contributor

nickodei commented Jan 6, 2025

@MartinZikmund Already embarked on this but fine, didn't matter.

Isn't it then implemented by your changes? What needs to be done?

@MartinZikmund
Copy link
Member Author

No, my changes just improve the StartStopEventWrapper API slightly, not in major way - should be easy to bring your changes up to date after it gets merged

@nickodei nickodei mentioned this issue Jan 7, 2025
Merged
6 tasks
@nickodei nickodei mentioned this issue Jan 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: Use shared StartStopTypedEventHandler for Sensors nickodei/uno
2 participants
@MartinZikmund @nickodei