Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logout redirection is hard coded #2

Open
ionparticle opened this issue Dec 17, 2013 · 0 comments · May be fixed by #5
Open

Logout redirection is hard coded #2

ionparticle opened this issue Dec 17, 2013 · 0 comments · May be fixed by #5

Comments

@ionparticle
Copy link
Contributor

When a user clicks logout, they get redirected to https://cas.usask.ca/cas/logout

Looks like the logout redirection url is hard coded here: https://github.com/usaskulc/cat/blob/master/cat/web/logout.jsp

Would be nice if it could be configurable.
ionparticle added a commit to ubc/cat that referenced this issue Feb 11, 2014
@ionparticle
Add CAS logout URL config in web.xml.
95b819e 
The CAS logout URL can now be configured in web.xml instead of being hard coded
in logout.jsp. This was done by adding a logout filter. Going to the url
/cat/auth/logout will now log you out of the application.

This also fixes a minor execution order bug on logout that leads to the session
persisting after the first logout. The execution flow in the original
logout.jsp goes: Application clears session, logout.jsp loads "My Courses"
page, logout.jsp goes to CAS logout page to clear CAS session. What happens in
our environment is that when logout.jsp loads "My Course", because its CAS
session hasn't been expired, it was able to reauthenticate and recreate the
application session. The workaround is to press logout again to truly logout.
The actual fix swaps the last two operations so that it goes: Application
clears session, redirects to CAS logout page to clear CAS session, redirects to
"My Courses".

Redirecting to "My Courses" needs to be done by the CAS server since the
browser was redirect to the CAS page. Luckily, there is a "service" parameter
that you can pass to the CAS logout url that tells the CAS server where to go
after logout.

Fixes usaskulc#2
@ionparticle ionparticle linked a pull request Feb 11, 2014 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CAS logout URL config in web.xml. ubc/cat
1 participant
@ionparticle