Skip to content

Latest commit

 

History

History
36 lines (28 loc) · 1.75 KB

PULL_REQUEST_TEMPLATE.md

File metadata and controls

36 lines (28 loc) · 1.75 KB

PLEASE REMOVE THE BELOW CHECKLIST BEFORE SUBMITTING

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

  • Make sure that your PR is not a duplicate.
  • You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/cudart_spec_build or feature/rdma_channel.
  • You have only one or a small number of commits (if not, squash some into one commit).
  • Linter doesn't throw any error. If it does, fix them first (e.g. ./scripts/check_cpp_format.sh -fix .) and amend your commit (git commit --amend).

PLEASE REMOVE THE ABOVE CHECKLIST BEFORE SUBMITTING

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document update (this change is mainly a documentation update)

Checklist:

  • My code passes format and lint checks.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested my code with a reasonable workload.
  • My code may break some other features.