Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why reexport std types? #74

Open
liigo opened this issue Jul 10, 2020 · 3 comments
Open

Why reexport std types? #74

liigo opened this issue Jul 10, 2020 · 3 comments

Comments

@liigo
Copy link

liigo commented Jul 10, 2020

data.rs:

pub use std::time::Duration;
pub use std::net::{Ipv4Addr, Ipv6Addr};
pub use std::collections::BTreeMap;
@valpackett
Copy link
Owner

yeah, given that the library exports data and doesn't take data from the user, they aren't really necessary

@dblclik
Copy link

dblclik commented Oct 18, 2022

@unrelentingtech - are you looking for a contributor to clean up the pub use std::... pieces? If so, would be happy to help as I plan to use this module in an upcoming project and like to give back when possible

@valpackett
Copy link
Owner

Not really.. ah I should've done this for the 0.2.x version bump. Well, I'll keep this for the next more-interesting API break I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants