Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResHacker Error: invalid command - Failed! - build.bat #78

Open
netgeek1 opened this issue Jul 23, 2020 · 10 comments
Open

ResHacker Error: invalid command - Failed! - build.bat #78

netgeek1 opened this issue Jul 23, 2020 · 10 comments

Comments

@netgeek1
Copy link

Recommend changing line 185 in build.bat

"%reshack%" -addoverwrite "%release_folder%\Portable-VirtualBox.tmp", "%release_folder%\%output_name%", "%build_folder%\Portable-VirtualBox\source\VirtualBox.ico",ICONGROUP,1,1033

Change from:
"%reshack%" -addoverwrite "%release_folder%\Portable-VirtualBox.tmp", "%release_folder%%output_name%", "%build_folder%\Portable-VirtualBox\source\VirtualBox.ico",ICONGROUP,1,1033

Change to:
"%reshack%" -open "%release_folder%\Portable-VirtualBox.tmp" -save "%release_folder%%output_name%" -action addoverwrite -res "%build_folder%\Portable-VirtualBox\source\VirtualBox.ico" -mask ICONGROUP,1,1033

This is based on receiving the follow error and based on batch examples from http://www.angusj.com/resourcehacker/
Commandline:
"C:\Program Files (x86)\Resource Hacker\ResourceHacker.exe" -addoverwrite "C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox.tmp", "C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox_current.exe", "C:\VirtualBox\Portable-VirtualBox2\build\source\Portable-VirtualBox\source\VirtualBox.ico",ICONGROUP,1,1033

Error: invalid command
Failed!

Batch file Examples (using rh.exe instead of ResourceHacker.exe in places for brevity)

reshack_help.bat:
ResourceHacker.exe -help
@Pause :: to see the console output before the CMD window closes.

reshack_compile_res_script.bat:
rh.exe -open .\in\resources.rc -save .\out\resources.res -action compile -log NUL

reshack_add_icon_to_old.bat:
rh.exe -open old.exe -save new.exe -action addskip -res my.ico -mask ICONGROUP,MAINICON,


Successful completion after modification of build.bat

_Commandline:
"C:\Program Files (x86)\Resource Hacker\ResourceHacker.exe" -open "C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox.tmp" -save "C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox_current.exe" -action addoverwrite -res "C:\VirtualBox\Portable-VirtualBox2\build\source\Portable-VirtualBox\source\VirtualBox.ico" -mask ICONGROUP,1,1033

Open : C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox.tmp
Save : C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox_current.exe
Resource: C:\VirtualBox\Portable-VirtualBox2\build\source\Portable-VirtualBox\source\VirtualBox.ico

Modified: ICONGROUP,1,1033

Success!_

@p060477
Copy link

p060477 commented Jul 23, 2020

..are you able to use network bridged with win 10 64 as host?

@netgeek1
Copy link
Author

..are you able to use network bridged with win 10 64 as host?

Unfortunately not. From reading some of the forums around issues with VBox bridged networking, it seems to require actual admin installation to put the driver in... I assume to a restricted location, so probably not compatible with portable versions...

@p060477
Copy link

p060477 commented Jul 23, 2020

infact..this is a very frustrating ISSUE..since 2015...
what a real pity...
thxs so much for yr precious witness

@AntarV1
Copy link

AntarV1 commented Jul 24, 2020

Bonjour
Vous décompressez l'archive et la placer à la racine de C et vous cliquez sur Vbox.bat et à la fin vous aurez votre vbox portable à son emplacement

VirtualBox.zip

@p060477
Copy link

p060477 commented Jul 24, 2020

Bonjour
Vous décompressez l'archive et la placer à la racine de C et vous cliquez sur Vbox.bat et à la fin vous aurez votre vbox portable à son emplacement

VirtualBox.zip

and in this case network bridged with win 10 64 as host works?

@AntarV1
Copy link

AntarV1 commented Jul 24, 2020

Chez moi ça marche depuis plusieurs mois et je suis en windows 10 2004 x64

@p060477
Copy link

p060477 commented Jul 24, 2020

Chez moi ça marche depuis plusieurs mois et je suis en windows 10 2004 x64

could you pls explain it clearly in english?
anyway in the readme text of yr zip file is clearly stated: NAT network..and NOT BRIDGED
so pls clarifly clearly
thxs

@p060477
Copy link

p060477 commented Jul 24, 2020

and yr .bat file is really NOT a bat file...
i really think that is MALAWARE and really hope that the admins here examine it
and remove it if i'm right

@AntarV1
Copy link

AntarV1 commented Jul 24, 2020

Je crois que vous ne savez pas ce que vous dites et que vous ne savez pas ce qu'est un fichier bat.Retirez vous svp

@p060477
Copy link

p060477 commented Jul 24, 2020

first here we ALL speak in english so yr behaviour is really unpolite and suspicious...
then:
EVERY bat file is openable with text editor
YOUR really NOT
i really hope that the admins here examine it well
for our SICURITY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants