-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResHacker Error: invalid command - Failed! - build.bat #78
Comments
..are you able to use network bridged with win 10 64 as host? |
Unfortunately not. From reading some of the forums around issues with VBox bridged networking, it seems to require actual admin installation to put the driver in... I assume to a restricted location, so probably not compatible with portable versions... |
infact..this is a very frustrating ISSUE..since 2015... |
Bonjour |
and in this case network bridged with win 10 64 as host works? |
Chez moi ça marche depuis plusieurs mois et je suis en windows 10 2004 x64 |
could you pls explain it clearly in english? |
and yr .bat file is really NOT a bat file... |
Je crois que vous ne savez pas ce que vous dites et que vous ne savez pas ce qu'est un fichier bat.Retirez vous svp |
first here we ALL speak in english so yr behaviour is really unpolite and suspicious... |
Recommend changing line 185 in build.bat
Portable-VirtualBox/build.bat
Line 185 in c6afcd6
Change from:
"%reshack%" -addoverwrite "%release_folder%\Portable-VirtualBox.tmp", "%release_folder%%output_name%", "%build_folder%\Portable-VirtualBox\source\VirtualBox.ico",ICONGROUP,1,1033
Change to:
"%reshack%" -open "%release_folder%\Portable-VirtualBox.tmp" -save "%release_folder%%output_name%" -action addoverwrite -res "%build_folder%\Portable-VirtualBox\source\VirtualBox.ico" -mask ICONGROUP,1,1033
This is based on receiving the follow error and based on batch examples from http://www.angusj.com/resourcehacker/
Commandline:
"C:\Program Files (x86)\Resource Hacker\ResourceHacker.exe" -addoverwrite "C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox.tmp", "C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox_current.exe", "C:\VirtualBox\Portable-VirtualBox2\build\source\Portable-VirtualBox\source\VirtualBox.ico",ICONGROUP,1,1033
Error: invalid command
Failed!
Batch file Examples (using rh.exe instead of ResourceHacker.exe in places for brevity)
reshack_help.bat:
ResourceHacker.exe -help
@Pause :: to see the console output before the CMD window closes.
reshack_compile_res_script.bat:
rh.exe -open .\in\resources.rc -save .\out\resources.res -action compile -log NUL
reshack_add_icon_to_old.bat:
rh.exe -open old.exe -save new.exe -action addskip -res my.ico -mask ICONGROUP,MAINICON,
Successful completion after modification of build.bat
_Commandline:
"C:\Program Files (x86)\Resource Hacker\ResourceHacker.exe" -open "C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox.tmp" -save "C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox_current.exe" -action addoverwrite -res "C:\VirtualBox\Portable-VirtualBox2\build\source\Portable-VirtualBox\source\VirtualBox.ico" -mask ICONGROUP,1,1033
Open : C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox.tmp
Save : C:\VirtualBox\Portable-VirtualBox2\build\release\Portable-VirtualBox_current.exe
Resource: C:\VirtualBox\Portable-VirtualBox2\build\source\Portable-VirtualBox\source\VirtualBox.ico
Modified: ICONGROUP,1,1033
Success!_
The text was updated successfully, but these errors were encountered: