[feature-request] Adapt S3 method conditional_effects
to bmmfit
objects.
#200
GidonFrischkorn
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
This would be great to have. Do you want to take a stab at it? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The
conditional_effects
methods works ok for mostbmmodels
, but I think we could add some tweaks to integrate it more seamlessly into the workflow ofbmm
. For example, currently users need to know explicitly if a model parameter is specified as adpar
ornlpar
when callingconditional_effects
. Moreover, fordpar
theconditional_effects
are transformed back to the native scale using the specified links, this is not the case fornlpars
.Here are some examples, for
conditional_effects
plots for the two-parameter mixture model.conditional_effects(ZL_fit, effects = "setsize", dpar = "kappa1")
yieldswhereas
conditional_effects(ZL_fit, effects = "setsize", nlpar = "kappa")
yields:For
theta1
versusthetat
i thought that having the plot on the probability scale is super useful, but again that only works when calling it via thedpar
:conditional_effects(ZL_fit, effects = "setsize", dpar = "theta1")
when called using the
nlpar
:conditional_effects(ZL_fit, effects = "setsize", nlpar = "thetat")
Ideally, we have an implementation of
conditional_effects
forbmmfit
objects that uses apar
argument to specify for which model parameter the effects should be plotted and maybe add an additionalscale
argument to specify if the plots should be given on theparameter
/sampling
scale or thenative
scale.What do you think @venpopov?
Beta Was this translation helpful? Give feedback.
All reactions