Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlining home route causes Link rel=preload to be omitted #3

Open
developit opened this issue Jan 25, 2018 · 1 comment
Open

Inlining home route causes Link rel=preload to be omitted #3

developit opened this issue Jan 25, 2018 · 1 comment

Comments

@developit
Copy link
Contributor

Hiya! I use this preact-cli configuration to turn off async component loading for my Home component:
https://github.com/developit/oss.ninja/blob/92643be13a90935a93b0c51e4ebf54e24371de1e/preact.config.js#L25-L32

It looks like that messes up this line, which results in the the headers for / being omitted:

/*
	Cache-Control: public, max-age=3600, no-cache
	Access-Control-Max-Age: 600
/sw.js
	Cache-Control: private, no-cache
/*.chunk.*.js
	Cache-Control: public, max-age=31536000
/license
	Link: </style.ec2d7.css>; rel=preload; as=style
	Link: </bundle.e384b.js>; rel=preload; as=script
	Link: </route-license.chunk.b2533.js>; rel=preload; as=script
@vinaypuppal
Copy link
Owner

Hi,
Sorry for responding late.

screen shot 2018-01-30 at 22 17 14

  • So I tried in preact-cli default template with developit/oss.ninja:preact.config.js as config file with this line commented out
 asyncPlugin(config);

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants