Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It doesn't detect SOF and EOF #1

Open
exothink opened this issue Jun 24, 2018 · 1 comment
Open

It doesn't detect SOF and EOF #1

exothink opened this issue Jun 24, 2018 · 1 comment

Comments

@exothink
Copy link

J1850 has more info than this lib decodes. This only works with itself and not J1850 PWM used commercially. It doesn't work because it doesn't detect start of frame, SOF, and end of frame, EOF.

It is only designed to decode characters, but can't do that if SOF is present. Also, because of its age it won't compile with the current 'digitalwritefast' lib.
@vittorioexp
Copy link
Owner

Thank you very much for your feedback.
Feel free to pull a fix if you want to.

@vittorioexp vittorioexp changed the title Not actually J1850 It doesn't dedect SOF and EOF Oct 8, 2020
@vittorioexp vittorioexp changed the title It doesn't dedect SOF and EOF It doesn't detect SOF and EOF Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@exothink @vittorioexp