Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add q.wg.Wait() to redisq.go #167

Closed
yedemon opened this issue Dec 17, 2021 · 2 comments
Closed

Please add q.wg.Wait() to redisq.go #167

yedemon opened this issue Dec 17, 2021 · 2 comments

Comments

@yedemon
Copy link
Contributor

yedemon commented Dec 17, 2021

After a carefully look, I found the wg in redisq.go is used only at RunQueue(), and has no Wait calls.

Should we add q.wg.Wait() to CloseTimeOut or some place else??

Because I'd really want to stop a running queue.

Please take this small quest into consideration. Thanks.. and thanks
@lilien1010
Copy link
Collaborator

Hi @yedemon I did some research on your question, can you setup a PR to fix it?

@yedemon
Copy link
Contributor Author

yedemon commented Mar 29, 2022

Sure, with pleasure. Here it's. #175

@yedemon yedemon closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yedemon @lilien1010