Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the contributors/repos/PRs items dynamic and hotlinks #24

Open
rnelson0 opened this issue Jan 2, 2016 · 13 comments
Open

Make the contributors/repos/PRs items dynamic and hotlinks #24

rnelson0 opened this issue Jan 2, 2016 · 13 comments

Comments

@rnelson0
Copy link
Member

rnelson0 commented Jan 2, 2016

The three items across the top appear static (https://github.com/puppet-community/puppet-community.github.io/blob/master/index.html#L32) and are not links to the appropriate sources.

@daenney
Copy link
Member

daenney commented Jan 2, 2016

Correct. Since pages are generated once this would need some client-side Javascript with the Github API to update those numbers.

@nibalizer
Copy link
Member

Bump

@daenney
Copy link
Member

daenney commented Jan 28, 2016

Bump yourself 😛. I'm not comfortable enough with JS to do this.

@daenney
Copy link
Member

daenney commented Aug 12, 2016

Mostly fixed with #60.

@daenney
Copy link
Member

daenney commented Aug 12, 2016

Ha, actually #60 "broke" something. Since we're using the GitHub API unauthenticated we only get 29 contributors now as that's the people that publicly advertise their membership.

@nibalizer
Copy link
Member

This is the more correct answer anyways. Maybe we should have something in our docs/CoC/whatever encouraging people to publish their membership so our number gets bigger?

@daenney
Copy link
Member

daenney commented Aug 12, 2016

Ya, works for me.

@rnelson0
Copy link
Member Author

So we just need the pull request data to be dynamic then?

@nibalizer
Copy link
Member

Yes. See the commit message on #60. It isn't super easy, will require going over a list of repos, getting #s of PRs, then summing them.

@rnelson0
Copy link
Member Author

rnelson0 commented Aug 13, 2016 via email

@bbriggs
Copy link
Contributor

bbriggs commented Dec 29, 2016

This is the more correct answer anyways. Maybe we should have something in our docs/CoC/whatever encouraging people to publish their membership so our number gets bigger?

Yes.

@foxxx0
Copy link
Member

foxxx0 commented Jan 18, 2017

I gave it a try, see: #91 :)

@bastelfreak
Copy link
Member

also #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants