Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to distinguish units in the instrument list (was: Numbered op list) #115

Open
wayfu opened this issue Nov 19, 2023 · 10 comments
Open
Labels
enhancement New feature or request

Comments

@wayfu
Copy link

wayfu commented Nov 19, 2023

To make it easier to keep track of multiple same ops in a row, it would be good to have a numbered list of ops in the instrument!

@wayfu
Copy link
Author

wayfu commented Nov 20, 2023

another cool feature would be the option to assign a color to ops in the op list

@vsariola
Copy link
Owner

To make it easier to keep track of multiple same ops in a row, it would be good to have a numbered list of ops in the instrument!

You mean the instrument editor should show the index of the unit to it left? That's super easy to do, but I wasn't sure that alone is helping too much + adds visual clutter in the GUI (it starts to be pretty busy already!).

another cool feature would be the option to assign a color to ops in the op list

I like this a lot more. One could color units to remind which one is which. I'll probably look into this.

@vsariola vsariola added the enhancement New feature or request label Nov 20, 2023
@vsariola vsariola changed the title Numbered op list Ability to distinguish units in the instrument list (was: Numbered op list) Nov 20, 2023
@wayfu
Copy link
Author

wayfu commented Nov 20, 2023

To make it easier to keep track of multiple same ops in a row, it would be good to have a numbered list of ops in the instrument!

You mean the instrument editor should show the index of the unit to it left? That's super easy to do, but I wasn't sure that alone is helping too much + adds visual clutter in the GUI (it starts to be pretty busy already!).

maybe make it an option then? it's how we choose targets in the send op, for example, and it would be good to have a direct reference in mind instead of say, counting filters to find the fifth one - for any op, not just the ones we've colored :)

edit: also, I wouldn't worry about clutter too much. A) consider your target audience B) you have a whole ass tracker in there already , with a screen full of letters, numbers and dots!

@vsariola
Copy link
Owner

vsariola commented Oct 14, 2024

Question: now that there is the ability to add a comment to each unit, is that enough?

Color seems a bit redundant, considering that a comment can be used for any text. Similarly, showing the line number seems not that useful as the line numbers tend to change all the time as you add units and delete units, so in practice finding the right send target just based on the line number is not that easy.

But if e.g. you have main envelope and another envelope for pitch drop, you could now comment them as "main" and "pitchdrop" and then finding them will be always easy.

I think this issue can be closed?

@wayfu
Copy link
Author

wayfu commented Oct 15, 2024

i can't find the comment-per-unit feature, is that in the release?

slot numbers are good because they happen automatically and don't require people to manually add comments to individual units; additionally, the send dropdown already shows them - nothing could be more intuitive, i think :)

@vsariola
Copy link
Owner

No, it's only in the latest master still, try the binaries from here: https://github.com/vsariola/sointu/actions/runs/11340616285

@wayfu
Copy link
Author

wayfu commented Oct 15, 2024

ah, got it working, thank you. i still think it makes sense to add the slot numbers, but this is already very nice. one detail that i think might be necessary is to make the unit pane resizable in width, there's not much space for unit comments:
image

@LeStahL
Copy link
Contributor

LeStahL commented Oct 20, 2024

The comment length seems to be capped at 16 chars. I love the feature tho, super cool that this works now :)

@vsariola
Copy link
Owner

vsariola commented Oct 20, 2024

The cap was kinda planned because my original plan was to show very little of the comment, just to avoid making the unit list resizeable. This way the user understands that the comments are mainly for distinguishing units, not for documentation (that is better done in the instrument comments). But I can remove the cap and stop the hand holding & just let the user do whatever she wants.

@wayfu
Copy link
Author

wayfu commented Oct 20, 2024

maybe there'll be enough space to display the slot number then?

  🥺 
 👉👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants