Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample-based oscillators have pitch instability with notes sustained for long #164

Open
rktic opened this issue Oct 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rktic
Copy link

rktic commented Oct 8, 2024

In both versions—native and non-native—sustaining notes using type 4/GM.dll samples drop pitch after a moment. Which gets really random with chords :)

To me, the GM samples are very interesting as wavetables. Offering a lot of potential for more effective/smaller patches. Which I'll definitely want to revisit in future projects. Would be great it the issue was fixed in future versions!

Steps to reproduce:

  1. Load Sointu Native
  2. Set oscillator type to 4
  3. Set sample 1
  4. Play and sustain any note
@vsariola vsariola added the bug Something isn't working label Oct 9, 2024
@vsariola
Copy link
Owner

vsariola commented Oct 9, 2024

This is a difficult to fix but I'll see what can I do. The reason is that oscillator phase is 32 bit floats and those pitch shifts are from rounding errors when adding a small value every sample to the phase.

@vsariola vsariola changed the title Oscillator type 4 pitch instability with sustained notes Sample-based oscillators have pitch instability with notes sustained for long Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants