Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scopes #61

Open
vsariola opened this issue Apr 15, 2021 · 2 comments
Open

Scopes #61

vsariola opened this issue Apr 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@vsariola
Copy link
Owner

We desperately need scopes. At least a scope for the master output, but the real game-changer would be adding "Scope" units in the synth, for displaying arbitrary signals in the scope.

@vsariola vsariola added the enhancement New feature or request label Apr 15, 2021
@vsariola
Copy link
Owner Author

Working on this one, first draft:

image

vsariola added a commit that referenced this issue Nov 2, 2024
In addition to the oscilloscope and loudness/peak detections, this
commit refactors all the channels between components (i.e.
ModelMessages and PlayerMessages) etc. into a new class Broker. This
was done because now we have one more goroutine running: a Detector,
where the loudness / true peak detection is done in another thread.
The different threads/components are only aware of the Broker and
communicate through it. Currently, it's just a collection of
channels, so it's many-to-one communication, but in the future,
we could change Broker to have many-to-one-to-many communication.

Related to #61
@vsariola
Copy link
Owner Author

vsariola commented Nov 2, 2024

Well, there's a rudimentary version there. I merged it as it was good enough, but not perfect. I will return to it to improve later, but I have a bunch of more urgent things to fix in the meanwhile. Still didn't want to leave this one completely out of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant