Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seek is collected and reran after a while (it was happening before over network) #200

Open
abdelaziz-mahdy opened this issue Dec 20, 2024 · 6 comments

Comments

@abdelaziz-mahdy
Copy link
Contributor

Describe the bug
This issue seems similar to [this one](#176), but in this case, it's happening with a local file. I'm not entirely sure what the root cause is.

The issue occurs when I use the keyboard to seek through the video. It sends a lot of seek requests, and the video initially plays correctly. However, after about 1 second, it sends what seems like 100 or more identical seek requests, causing the playback to jump forward unexpectedly.

I’m unsure of the proper fix. I could debounce the requests on my side to limit how quickly they are sent, but I don’t think that’s the right solution. If you can identify the issue from the logs, I’d appreciate your insights.


Expected behavior
Once seeking is completed, no additional seek requests should be triggered.


Log
[Log Link](https://justpaste.it/crzw2)

@wang-bin
Copy link
Owner

player.seek( or ::seekTo(: 50 lines. seekComplete# 52 lines - not found @ 3 lines, ::seekTo( max id is 50, seekComplete# max id is 50, looks good

@abdelaziz-mahdy
Copy link
Contributor Author

So it should be limited from my side using a denouncer?

@wang-bin
Copy link
Owner

yes

@abdelaziz-mahdy
Copy link
Contributor Author

can seeks be ignored if another request is sent to mdk? that will much better than a debouncer from my side since there might be loading happening or other stuff in older requests that mdk is handling so mdk ignoring the old requests is much better

@wang-bin
Copy link
Owner

wang-bin commented Dec 24, 2024

if previous seeking is not finished, new seek is ignored. in your log, seeking is fast so none is ignored

@abdelaziz-mahdy
Copy link
Contributor Author

Oh, it's already implemented then, I will check it again maybe its a problem from my side then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants