From 83edd3f0308718ec2eb6fe753854997606d2b354 Mon Sep 17 00:00:00 2001
From: Thorben Nissen <thorben@webcoast.dk>
Date: Fri, 2 Feb 2024 12:18:40 +0100
Subject: [PATCH] [BUGFIX] Do not render menus, if settings are empty

Check if there are pages selected in the respective menu field before running the data actual processing
to avoid menu pages determined from empty settings.
---
 ext_localconf.php | 36 +++++++++++++++++++++++++++---------
 1 file changed, 27 insertions(+), 9 deletions(-)

diff --git a/ext_localconf.php b/ext_localconf.php
index 081761d..2afc9d3 100644
--- a/ext_localconf.php
+++ b/ext_localconf.php
@@ -10,12 +10,31 @@
 
         $menuIndex = 100;
         foreach ($menuConfiguration->getActiveMenus() as $menu => $configuration) {
-            $typoScriptSetup .= sprintf(
-<<<EOTS
-page.20.dataProcessing.{$menuIndex} = %s
-page.20.dataProcessing.{$menuIndex} {
-    as = menu%s
-    levels = %s
+            $typoScriptSetup .= sprintf('
+page.20.dataProcessing.%1$d = %2$s
+page.20.dataProcessing.%1$d {
+    as = menu%3$s
+    levels = %4$s
+    if.isTrue.cObject = CONTENT
+    if.isTrue.cObject {
+        table = pages
+        select {
+            pidInList.data = leveluid:0
+            recursive = 10
+            join = tx_editablemenus_menu_pages_mm m ON m.uid_foreign=pages.uid
+            where {
+                data = leveluid:0
+                wrap = {#m.field_name} = "%5$s_menu" AND {#m.uid_local}=|
+            }
+            orderBy = m.sorting asc
+        }
+        renderObj = TEXT
+        renderObj {
+            field = uid
+            wrap = |,
+        }
+        stdWrap.substring = 0,-1
+    }
     special = list
     special.value.cObject = CONTENT
     special.value.cObject {
@@ -26,7 +45,7 @@
             join = tx_editablemenus_menu_pages_mm m ON m.uid_foreign=pages.uid
             where {
                 data = leveluid:0
-                wrap = {#m.field_name} = "%s_menu" AND {#m.uid_local}=|
+                wrap = {#m.field_name} = "%5$s_menu" AND {#m.uid_local}=|
             }
             orderBy = m.sorting asc
         }
@@ -38,8 +57,7 @@
         stdWrap.substring = 0,-1
     }
 }
-
-EOTS, \TYPO3\CMS\Frontend\DataProcessing\MenuProcessor::class, \TYPO3\CMS\Core\Utility\GeneralUtility::underscoredToUpperCamelCase($menu), $configuration['levels'] ?? 1, $menu
+', $menuIndex, \TYPO3\CMS\Frontend\DataProcessing\MenuProcessor::class, \TYPO3\CMS\Core\Utility\GeneralUtility::underscoredToUpperCamelCase($menu), $configuration['levels'] ?? 1, $menu
         );
 
             ++$menuIndex;