Shouldn't ScalarType::parseValue throw UserError instead of Error?

[davidPaymefy]

Hello, I have this problem:

When a client sends a string instead of an integer as input ("10" vs 10), IntType throws a GraphQL\Error\Error and pollutes the log. I don't want to log this errors.

I need a way to distinguish errors due to user sending wrong input from other internal errors. Shouldn't ScalarType::parseValue throw UserError instead of Error, or am I wrong?

I would appreciate some feedback on this. Thanks in advance.

[spawnia]

See

graphql-php/src/Error/Error.php

Lines 21 to 22 in 7cd7412

	* Describes an Error found during the parse, validate, or
	* execute phases of performing a GraphQL operation. In addition to a message

I don't want to log this errors.

Then don't.

[davidPaymefy]

Thanks for you reply, but what does execute phase mean? Could it be an internal error? Because, if yes, I do want to log that.

[spawnia]

It is a user-facing error.

[davidPaymefy]

That's not what I'm asking. As and example, making a parallelism with an API REST, both a 500 and a 404 response are user-facing errors, but I will only want to log the 500.

[spawnia]

My response was not clearly phrased. GraphQL\Error\Error is used for errors caused by the user. For developer errors, this library uses GraphQL\Error\InvariantViolation.

[davidPaymefy]

Ok, I see, thank you very much. Everything is clear now.