-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior of updating the checkedness state of the elements in the same radio button group is unclear #10897
Comments
cc @domfarolino |
…input is appended to a disconnected subtree See whatwg/html#10897. Differential Revision: https://phabricator.services.mozilla.com/D233421 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1938489 gecko-commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a gecko-reviewers: avandolder
… when a radio input is appended to a disconnected subtree; r=avandolder See whatwg/html#10897. Differential Revision: https://phabricator.services.mozilla.com/D233421
…input is appended to a disconnected subtree See whatwg/html#10897. Differential Revision: https://phabricator.services.mozilla.com/D233421 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1938489 gecko-commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a gecko-reviewers: avandolder
…input is appended to a disconnected subtree See whatwg/html#10897. Differential Revision: https://phabricator.services.mozilla.com/D233421 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1938489 gecko-commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a gecko-reviewers: avandolder
… when a radio input is appended to a disconnected subtree; r=avandolder See whatwg/html#10897. Differential Revision: https://phabricator.services.mozilla.com/D233421
While I'd love to get rid of the COMEFROM-ey "becomes foo" hooks, I don't think that dream should block this issue, and adding "becomes connected" to the list makes a lot of sense. Do you know if there are WPTs for this @EdgarChen? If so we can get a PR up for this I think. |
There are some WPTs add in https://bugzilla.mozilla.org/show_bug.cgi?id=1938489 which would be merged in web-platform-tests/wpt#50048. I will prepare a PR for this. |
…o becomes connected Closes whatwg#10897.
… when a radio input is appended to a disconnected subtree; r=avandolder See whatwg/html#10897. Differential Revision: https://phabricator.services.mozilla.com/D233421 UltraBlame original commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
… when a radio input is appended to a disconnected subtree; r=avandolder See whatwg/html#10897. Differential Revision: https://phabricator.services.mozilla.com/D233421 UltraBlame original commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
… when a radio input is appended to a disconnected subtree; a=RyanVM See whatwg/html#10897. Original Revision: https://phabricator.services.mozilla.com/D233421 Differential Revision: https://phabricator.services.mozilla.com/D234285
… when a radio input is appended to a disconnected subtree; r=avandolder See whatwg/html#10897. Differential Revision: https://phabricator.services.mozilla.com/D233421 UltraBlame original commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
… when a radio input is appended to a disconnected subtree; a=RyanVM See whatwg/html#10897. Original Revision: https://phabricator.services.mozilla.com/D233421 Differential Revision: https://phabricator.services.mozilla.com/D234285
What is the issue with the HTML Standard?
https://html.spec.whatwg.org/multipage/input.html#radio-button-state-(type=radio) lists the cases where the checkedness state of elements in the same radio button group should update,
However, all browsers also update the checkedness state of elements in the same radio button group when the element becomes connected. Note that Chrome/Safari don't update the checkedness state of elements in the same radio button group when the element is appended to a disconnected subtree and the form owner remains unchanged, e.g. https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=13369. Some pages rely on this behavior, see the report in https://bugzilla.mozilla.org/show_bug.cgi?id=1938489, so we are going to behave the same in Gecko for compatibility. I suggest we also make it clear in the spec by perhaps adding
into https://html.spec.whatwg.org/multipage/input.html#radio-button-state-(type=radio)?
The text was updated successfully, but these errors were encountered: