Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of updating the checkedness state of the elements in the same radio button group is unclear #10897

Open
EdgarChen opened this issue Jan 7, 2025 · 3 comments · May be fixed by #10917
Labels
compat Standard is not web compatible or proprietary feature needs standardizing topic: forms

Comments

@EdgarChen
Copy link
Member

What is the issue with the HTML Standard?

https://html.spec.whatwg.org/multipage/input.html#radio-button-state-(type=radio) lists the cases where the checkedness state of elements in the same radio button group should update,

When any of the following phenomena occur, if the element's checkedness state is true after the occurrence, the checkedness state of all the other elements in the same radio button group must be set to false:

However, all browsers also update the checkedness state of elements in the same radio button group when the element becomes connected. Note that Chrome/Safari don't update the checkedness state of elements in the same radio button group when the element is appended to a disconnected subtree and the form owner remains unchanged, e.g. https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=13369. Some pages rely on this behavior, see the report in https://bugzilla.mozilla.org/show_bug.cgi?id=1938489, so we are going to behave the same in Gecko for compatibility. I suggest we also make it clear in the spec by perhaps adding

  • The element becomes connected.

into https://html.spec.whatwg.org/multipage/input.html#radio-button-state-(type=radio)?

@annevk annevk added compat Standard is not web compatible or proprietary feature needs standardizing topic: forms labels Jan 7, 2025
@annevk
Copy link
Member

annevk commented Jan 7, 2025

cc @domfarolino

moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 13, 2025
…input is appended to a disconnected subtree

See whatwg/html#10897.

Differential Revision: https://phabricator.services.mozilla.com/D233421

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1938489
gecko-commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
gecko-reviewers: avandolder
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 13, 2025
… when a radio input is appended to a disconnected subtree; r=avandolder

See whatwg/html#10897.

Differential Revision: https://phabricator.services.mozilla.com/D233421
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 14, 2025
…input is appended to a disconnected subtree

See whatwg/html#10897.

Differential Revision: https://phabricator.services.mozilla.com/D233421

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1938489
gecko-commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
gecko-reviewers: avandolder
sadym-chromium pushed a commit to web-platform-tests/wpt that referenced this issue Jan 14, 2025
…input is appended to a disconnected subtree

See whatwg/html#10897.

Differential Revision: https://phabricator.services.mozilla.com/D233421

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1938489
gecko-commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
gecko-reviewers: avandolder
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Jan 14, 2025
… when a radio input is appended to a disconnected subtree; r=avandolder

See whatwg/html#10897.

Differential Revision: https://phabricator.services.mozilla.com/D233421
@domfarolino
Copy link
Member

While I'd love to get rid of the COMEFROM-ey "becomes foo" hooks, I don't think that dream should block this issue, and adding "becomes connected" to the list makes a lot of sense. Do you know if there are WPTs for this @EdgarChen? If so we can get a PR up for this I think.

@EdgarChen
Copy link
Member Author

There are some WPTs add in https://bugzilla.mozilla.org/show_bug.cgi?id=1938489 which would be merged in web-platform-tests/wpt#50048. I will prepare a PR for this.

EdgarChen added a commit to EdgarChen/html that referenced this issue Jan 15, 2025
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jan 16, 2025
… when a radio input is appended to a disconnected subtree; r=avandolder

See whatwg/html#10897.

Differential Revision: https://phabricator.services.mozilla.com/D233421

UltraBlame original commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Jan 16, 2025
… when a radio input is appended to a disconnected subtree; r=avandolder

See whatwg/html#10897.

Differential Revision: https://phabricator.services.mozilla.com/D233421

UltraBlame original commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 16, 2025
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jan 16, 2025
… when a radio input is appended to a disconnected subtree; r=avandolder

See whatwg/html#10897.

Differential Revision: https://phabricator.services.mozilla.com/D233421

UltraBlame original commit: 855cfa4c4274f83399358bf24c316d39bdc6a75a
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat Standard is not web compatible or proprietary feature needs standardizing topic: forms
3 participants