Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition bug in generateFigure() #7

Open
seav opened this issue Jun 6, 2019 · 0 comments
Open

Fix race condition bug in generateFigure() #7

seav opened this issue Jun 6, 2019 · 0 comments
Labels

Comments

@seav
Copy link
Member

seav commented Jun 6, 2019

In the JS file eph-common.js, the generateFigure() function assumes that the <figcaption> that is the target of the AJAX operation is still attached to the document when the AJAX resolves. But the user may have switched the panel contents before the AJAX resolves leading to either the wrong photo attribution being added or not being able to attach the photo attribution.

The obvious solution is to update the function to refer to the panelElem Records field.

@seav seav added the bug label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant