where is the on_server_ready?

[nyngwang]

Try to migrate from installer. My old codes are:

    require('nvim-lsp-installer').on_server_ready(
      function (server)
        local has_config, config = pcall(require, 'lsp_config.'..server.name)
        if not has_config then
          server:setup(require('lsp_config.default')) return end
        server:setup(config)
      end
    )

how should I do the same using mason?

[williamboman]

Hello! The on_server_ready function was deprecated a while back, mostly due to how it wrapped lspconfig and was causing confusion. There is a similar alternative in the mason-lspconfig extension (to be documented), try this:

require("mason").setup()
require("mason-lspconfig").setup()

-- the above is enough, but if you want to replicate the "on_server_ready" behaviour
-- where your installed servers are setup "automatically" you can do the following
require("mason-lspconfig").setup_handlers {
    -- default handler - setup with default settings
    function (server_name)
        lspconfig[server_name].setup {}
    end,
   -- you can override the default handler by providing custom handlers per server
   ["jdtls"] = function ()
       // do something with the nvim-jdtls plugin instead
   end
}

Note that the require("mason-lspconfig").setup_handlers functions is not stable yet

[williamboman]

Yeo, check :h mason-lspconfig!

[punowo]

Yeo, check :h mason-lspconfig!

Sorry, I'm not sure that I understand. You mean I can also use ensure_installed from mason-lspconfig for stuff like shfmt and then use mason-registry to get all installed packages, filter by CAT and then get the commands of these and pass them onto null-ls ?
Won't the generic handler try and start them, or is it already limited by the LSP category.

[williamboman]

The mason-lspconfig module is exclusively only for lspconfig-related functionality. So anything in mason-lspconfig is strictly limited to LSP servers. Also I’m not sure I’m following the relationship of ensure_installed and getting all installed packages? In the context of the null-ls question, let’s pretend mason-lspconfig doesnt exist. Yeah sure that sounds doable. I’m not sure you’ll need to specify any commands yourself as this is all handled by null-ls - I guess the only thing you need to do is map a Mason package to a null-ls ”source”? Something like:

— Maps a Mason package name to a null-ls source
local source_map = {
    stylua = require("null-ls").builtins.formatting.stylua,
    cspell = require("null-ls").builtins.diagnostics.cspell
}

local sources = {}

for _, pkg in ipairs(mason_registry.get_installed_package_names()) do
  if source_map[pkg_name] then
     table.insert(sources, source_map[pkg_name])
  end
end

require("null-ls").setup({
    sources = sources
})

On mobile atm so prob a few mistakes but hopefully you get the idea.

edit: this could probably turn into a very helpful mason-null-ls plugin 🤷‍♂️

[punowo]

The mason-lspconfig module is exclusively only for lspconfig-related functionality. So anything in mason-lspconfig is strictly limited to LSP servers.

That is intuitive and the obvious answer, but it wasn't clear 100% to me, thank you. I thought it might also be used to install other Mason packages, not just LSPs.

Also I’m not sure I’m following the relationship of ensure_installed and getting all installed packages? In the context of the null-ls question, let’s pretend mason-lspconfig doesnt exist.

I'm looking for a way to not install them manually, as you can see from this piece of lua I posted above:

 local formatters = { "shfmt", "stylua" }

  for _, name in ipairs(formatters) do
      local formatter_is_found = format_install.exists(name)
      if formatter_is_found then
          if not format_install.is_installed(name) then
              format_install.install_formatter(name)
          end
      end
  end -- automatically install all formatters

  for _, formatter in ipairs(format_install.get_installed_formatters()) do
      if not util.set_contains_val(formatters, formatter.name) then
          format_install.uninstall_formatter(formatter.name)
      end
  end -- automatically uninstall all not needed formatters

My ideal case would be something like this that would also include a part for updating Mason packages. (I believe it was mentioned in another post of yours on the nvim-lsp-installer discussion / issue github section).

To expand a little on this, I would like to just have a list somewhere in my config where I can declare what mason packages I want and then have a few lines of code to handle if they should be installed, if a mason package is present but should be uninstalled or to update them without having to call :MasonInstall/MasonUninstall <package> ... manually.

Then with all the Mason packages in order, if possible, I would create separate lists based on the category of the mason package and eventually make null-ls work nice with them using my initial approach or something similar to how you did it except maybe add a prefix because some software has multiple null-ls builtins (example: shellcheck which has both linter and code_action)

[nyngwang]

@williamboman I have a very long time not following this project. Is the code answer here stable now? If not where could I find the stable version?