Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] “添加翻译到笔记”无法关闭 #1046

Closed
3 tasks done
wytWangLei opened this issue Jan 7, 2025 · 1 comment · Fixed by #1062
Closed
3 tasks done

[Bug] “添加翻译到笔记”无法关闭 #1046

wytWangLei opened this issue Jan 7, 2025 · 1 comment · Fixed by #1062
Assignees
@windingwind
Labels
bug Something isn't working

Comments

@wytWangLei
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you checked the FAQ (#6)?

  • I have checked the FAQ

Are you using the latest Zotero and the latest plugin?

  • I have confirmed I'm using the latest Zotero and the latest plugin

Environment

  • OS: win11 23H2 22631.4602
  • Zotero Version: 7.0.12-beta.1+31bbf2acf (64-bit)
  • Plugin Version: 2.1.0

Describe the bug

关闭“在弹窗显示‘添加翻译到笔记’”的功能后，选中文字还是会显示添加翻译到笔记的框
image
image

Debug Output

——

Anything else?

No response
@wytWangLei wytWangLei added the bug Something isn't working label Jan 7, 2025
@wytWangLei wytWangLei changed the title [Bug] [Bug] “添加翻译到笔记”无法关闭 Jan 16, 2025
ramonmi added a commit to ramonmi/zotero-pdf-translate that referenced this issue Jan 19, 2025
@ramonmi
fix: show AddToNote in pupop even if unchecked (windingwind#1046)
0858341
@ramonmi ramonmi mentioned this issue Jan 19, 2025
Merged
windingwind added a commit that referenced this issue Jan 19, 2025
@ramonmi @windingwind
fix: show AddToNote in pupop even if unchecked (#1046) (#1062)
02a37f4 
* fix: show AddToNote in pupop even if unchecked (#1046)

* chore: lint

---------

Co-authored-by: windingwind <33902321+windingwind@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

🚀 This ticket has been resolved in v2.1.2. See Release v2.1.2 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@windingwind windingwind

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show AddToNote in pupop even if unchecked (#1046) ramonmi/zotero-pdf-translate
2 participants
@windingwind @wytWangLei