From 663f0a268a84e8a3611ba18f5e26315767a7162d Mon Sep 17 00:00:00 2001 From: kungfucraig Date: Wed, 18 Dec 2024 00:40:52 +0000 Subject: [PATCH] update comments --- .../measurement/reporting/v2alpha/page.proto | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/main/proto/wfa/measurement/reporting/v2alpha/page.proto b/src/main/proto/wfa/measurement/reporting/v2alpha/page.proto index d21327191dc..4f402d2d217 100644 --- a/src/main/proto/wfa/measurement/reporting/v2alpha/page.proto +++ b/src/main/proto/wfa/measurement/reporting/v2alpha/page.proto @@ -76,11 +76,13 @@ message CalculationSpec { // Only those event template fields that are tagged as groupable // and in the common template are supported. message Grouping { - // A field path with respect to the Event message that indicates the - // dimension to group by. + // A set field paths that indicate the dimensions to group by. // - // For example, if there is an event tempalte field in common - // named "age_group" then this value should be common.age_group + // Each field path is with respect to the Event message with `.` as the + // traversal operator. + // + // For example, if the Event message had an Event Template `common` with + // a field `age_group` then the field path would be `common.age_group`. repeated string event_template_field = 1 [ (google.api.field_behavior) = REQUIRED, (google.api.field_behavior) = IMMUTABLE @@ -98,11 +100,10 @@ message CalculationSpec { // // Negation may be supported in the future. message Term { - // A field path with respect to the Event message that indicates the - // dimension to apply the filter to. + // A field path indicating a dimension to filter on. // - // For example, if there is an event tempalte field in common - // named "age_group" then this value should be common.age_group + // See Grouping.event_template_field for a complete description of + // what is meant by "field path." string event_template_field = 1 [ (google.api.field_behavior) = REQUIRED, (google.api.field_behavior) = IMMUTABLE