Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListEventGroup API response is slow, when no CEL filter or keyword search results are found #1941

Closed
nitamanna18 opened this issue Nov 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nitamanna18
Copy link

Describe the bug
When the ListEventGroup API cannot find results, the response time increases significantly, taking up to 54 seconds. However, when results are found, the API responds almost instantly (within milliseconds).
We made only one call from Origin Reports Adaptor (screenshot below) but we noticed 3 request to Kingdom log(screenshot below) for the same single request which returns the same result within 600 ms.

Kingdom Log:
image

Origin Reports Adaptor Log
image

Steps to reproduce

  1. Login to Origin Platform
  2. Go to Campaign group page
  3. Search for Event Groups without any filters and the EGs not found in UI
  4. Click on “Search“ button to call listeventgroup API

Component(s) affected
Kingdom, Reporting Server

Version
Halo 5.11

Environment
Origin Stage & PROD Environment

Additional context
attached log screenshot above.

@nitamanna18 nitamanna18 added the bug Something isn't working label Nov 29, 2024
@SanjayVas
Copy link
Member

SanjayVas commented Dec 2, 2024

We made some performance enhancements to ListEventGroups in v0.5.13 as part of fixing a previous simulator issue. See #1923. Feel free to reopen if you still see the same problem after upgrading past that version.

The behavior is that it attempts to read as many results as it can before the RPC deadline, assuming that the overhead for calling the Kingdom is 100ms1. If the caller has not specified a deadline2, the service will use 30s.

As an aside, all issues filed here should be in the context of Halo software only. This means that the "Step to reproduce" should only cover parts of Halo. For the purposes of filing issues here, assume that the Origin UI doesn't exist.

Footnotes

  1. We should probably go back and make this configurable

  2. This should ideally never be true, as the caller should always specify an RPC deadline

@SanjayVas SanjayVas closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants