Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor subscribers to act as controllers #1

Open
remyperona opened this issue Jun 3, 2020 · 0 comments
Open

Refactor subscribers to act as controllers #1

remyperona opened this issue Jun 3, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@remyperona
Copy link
Contributor

Currently the subscribers are doing too much, they should be used as controllers to register the callbacks and delegate the processing to the appropriate classes/services.

We need to refactor the code to split it between subscribers and classes/services.

A proposed architecture:

  • Admin
    • AdminPage
    • AJAX
    • Notices
    • Subscriber, using the 3 classes above as dependencies
  • REST
    • Handler
    • Subscriber
  • APIClient
  • CDNOptionsManager
  • ServiceProvider
@remyperona remyperona added the enhancement New feature or request label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remyperona