-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calculation for two-photon continuum #43
Comments
The Chianti routine has lots of options in terms of inputs, outputs, and keywords. What input/output (variables, units, etc.) would be preferred here? |
Good question. Looking at the list of input parameters, I would say most are not needed due to the design of fiasco, e.g. sngl_ion or element do not need to be specified because this will be a method on an Ion class. In an effort to keep the API as similar to that of the free-free and free-bound methods, I would say we should aim to just have wavelength and density be the inputs. We could consider implementing a minimum abundance optional input too but that would be applied at the level of the method on |
Semi unrelated but the only reference I've found w.r.t. how this is implemented in CHIANTI is Eq 4 of this paper: http://adsabs.harvard.edu/abs/1999A%26AS..135..339L. |
Actually, equation 11 of this paper and the accompanying text are much more helpful: http://adsabs.harvard.edu/abs/2003ApJS..144..135Y |
The hydrogenic calculation uses both
I'm assuming this is folded into the definition of the spectral distribution function, but I'm not sure I know what that function is. Do you have any idea? |
I think all of this information is available in the |
Oh, for sure I can translate the code. I'm just wondering what it actually is, and what these equations actually are. There's no mention of |
It's certainly quite mysterious. The only thing I can find is this note in the IDL docstring:
This maybe explains why the spectral distribution function for the H-like ions is normalized by @pryoung do you know why these |
I can't access the Drake papers, but this one has a simple definition of the spectral distribution function: No mention of One more inquiry: should H: |
Yeah, something about the units is not right. I think when I wrote the parser I assumed the units of We should just elevate this to the CHIANTI mailing list as I'm sure either Ken or Peter knows. Maybe some normalization was applied when the files were prepared. |
I'll send an e-mail. Not having much luck figuring it out otherwise. |
Cross referencing chianti-atomic/ChiantiPy#458 for completeness |
Think I sort of figured out The IDL code has the following comments:
which seems to check out for any element. This would indeed be unitless, then. In any case, I think we should come up with a better name. It has nothing to do with the |
Oh great! I don't know how I missed that comment. I suppose me naively assuming A_ij and A_sum are related and thus must have the same units is what led to all of this confusion! I completely agree re: a new name. Maybe something like |
Thanks for sorting this out – I made a start on a technical report for the two-photon continuum, so I’ll give this a mention. Peter.
From: Will Barnes ***@***.***>
Reply-To: wtbarnes/fiasco ***@***.***>
Date: Thursday, February 15, 2024 at 12:11 AM
To: wtbarnes/fiasco ***@***.***>
Cc: Peter Young ***@***.***>, Mention ***@***.***>
Subject: [EXTERNAL] [BULK] Re: [wtbarnes/fiasco] Add calculation for two-photon continuum (#43)
CAUTION: This email originated from outside of NASA. Please take care when clicking links or opening attachments. Use the "Report Message" button to report suspicious messages to the NASA SOC.
Oh great! I don't know how I missed that comment.
I completely agree re: a new name. Maybe something like psi_norm? And then in the description field we can give more details. Let's also try to preserve some of this discussion in a comment somewhere in the code since it doesn't seem to appear anywhere else in the CHIANTI papers, software, or docs!
—
Reply to this email directly, view it on GitHub<#43 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEL4UCGJ2WEXSGBIJGCS3H3YTWKIBAVCNFSM4GQQRLN2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJUGUZTQMRTGIYQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No description provided.
The text was updated successfully, but these errors were encountered: