Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call and intensity sanity check #63

Open
dkj opened this issue Apr 10, 2013 · 3 comments
Open

call and intensity sanity check #63

dkj opened this issue Apr 10, 2013 · 3 comments

Comments

@dkj
Copy link
Member

dkj commented Apr 10, 2013

ensure called base is the one with highest corrected intensity when applying (and calibrating?) qualities - an assert?

@srl147
Copy link
Contributor

srl147 commented Jun 11, 2013

The bases are called by RTA, which treats the intensities as floating point numbers so the channel with the maximum intensity is unique. The cif/dif files contain integers, in practice there are a significant number of bases where multiple channels match the maximum intensity. In src/calibration_pu.c uncomment

//#define CHECK_BASECALL

if you want to do this check. This finds the largest intensity and then checks that called base corresponds to a channel with this intensity

@dkj
Copy link
Member Author

dkj commented Jul 7, 2013

We need to turn this into a assert which runs all the time (to catch problems arising from when we've altered other bits of the pipeline e.g. composing read from a subset of cycles).

@dkj
Copy link
Member Author

dkj commented Jul 9, 2013

And we need this check in predictor_pu i.e. it's most important to confirm base called is base with max intensity where we actually set the qualities....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants