Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polygon rendering hacks #7

Open
xTibor opened this issue Aug 29, 2022 · 0 comments
Open

Remove polygon rendering hacks #7

xTibor opened this issue Aug 29, 2022 · 0 comments

Comments

@xTibor
Copy link
Owner

xTibor commented Aug 29, 2022

egui currently doesn't support rendering concave polygons, so egui_extras_xt have to use the convex polygon rendering methods with some hacks to render concave polygons. Remove these workarounds when egui gets support for rendering concave polygons.

emilk/egui#513

Affected places and hacks:

  • WidgetShape::paint_shape: manual tessalation with two-stage rendering
  • WidgetShape::paint_arc: manual tessalation with two-stage rendering, additional special case for misrendered degenerate polygons
  • CompassMarkerShape::Star: no hacks, broken polygons are barely visible at small sizes
  • SegmentedDisplayWidget::ui: manually reordered segment vertices to avoid visible artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant