Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files installed through as_utils_install_metadata_file() have executable bit set #681

Closed
mcrha opened this issue Nov 11, 2024 · 3 comments · May be fixed by #694
Closed

Files installed through as_utils_install_metadata_file() have executable bit set #681

mcrha opened this issue Nov 11, 2024 · 3 comments · May be fixed by #694

Comments

@mcrha
Copy link

mcrha commented Nov 11, 2024

When a file is installed through as_utils_install_metadata_file(), it has set the executable bit in the destination. See:

$ ls -l /var/cache/swcatalog/xml/
-rwxr-xr-x. 1 root root 5719 Nov 11 15:43 rpmfusion-nonfree-steam.xml

This is with appstream-1.0.2-4.fc41.x86_64

@ximion ximion closed this as completed in c6903ab Dec 8, 2024
@mcrha
Copy link
Author

mcrha commented Dec 9, 2024

Hmm, I'm pretty sure the source file does not have set the executable bit, while the destination does have it set (even when it does not exist yet). Your change suggests the problem can be somewhere else, somewhere deeper, because you do not fiddle with the file attributes at all, furthermore you let glib to "inherit the file attributes from the source file", which makes it confusing, like if the problem was in the glib itself.

@mcrha
Copy link
Author

mcrha commented Jan 16, 2025

I'm reopening this, the problem is still present.

mcrha added a commit to mcrha/appstream that referenced this issue Jan 16, 2025
The file has set the attributes after commit c6903ab,
thus this is not needed.

If it was meant to set the executable flag on the parent directory, then it
is not needed either, at least according to my tests. The `path_dest` points
to the installed file here, not to the parent directory.

Closes ximion#681
@mcrha
Copy link
Author

mcrha commented Jan 16, 2025

See #694 for my finding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant