-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files installed through as_utils_install_metadata_file() have executable bit set #681
Comments
Hmm, I'm pretty sure the source file does not have set the executable bit, while the destination does have it set (even when it does not exist yet). Your change suggests the problem can be somewhere else, somewhere deeper, because you do not fiddle with the file attributes at all, furthermore you let glib to "inherit the file attributes from the source file", which makes it confusing, like if the problem was in the glib itself. |
I'm reopening this, the problem is still present. |
The file has set the attributes after commit c6903ab, thus this is not needed. If it was meant to set the executable flag on the parent directory, then it is not needed either, at least according to my tests. The `path_dest` points to the installed file here, not to the parent directory. Closes ximion#681
See #694 for my finding. |
When a file is installed through
as_utils_install_metadata_file()
, it has set the executable bit in the destination. See:This is with appstream-1.0.2-4.fc41.x86_64
The text was updated successfully, but these errors were encountered: