Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRY (Don't repeat yourself) not used? #97

Open
ClausKlein opened this issue Sep 8, 2024 · 1 comment
Open

TRY (Don't repeat yourself) not used? #97

ClausKlein opened this issue Sep 8, 2024 · 1 comment

Comments

@ClausKlein
Copy link

ClausKlein commented Sep 8, 2024

see too Don't repeat yourself

Why ist HDK_ROOT_DIRECTORY defined, but mostly not use inside the cmake modules?

bash-5.2$ grep -rw '\.hadouken' *.cmake cmake/
hadouken.cmake:set(HDK_ROOT_DIRECTORY     ${HDK_ROOT_PROJECT_SOURCE_DIR}/.hadouken)
hadouken.cmake:set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${PROJECT_SOURCE_DIR}/.hadouken/cmake/modules/)
hadouken.cmake:set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${PROJECT_SOURCE_DIR}/.hadouken/cmake/modules/find)
hadouken.cmake:file(GLOB CORE_MODULES "${PROJECT_SOURCE_DIR}/.hadouken/cmake/modules/core/*.cmake")
hadouken.cmake:file(GLOB TOOLCONF_MODULES "${PROJECT_SOURCE_DIR}/.hadouken/cmake/modules/toolconf/*.cmake")
hadouken.cmake:file(GLOB WRAPPER_MODULES "${PROJECT_SOURCE_DIR}/.hadouken/cmake/modules/wrappers/*.cmake")
cmake//modules/core/MakeComponent.cmake:include(.hadouken/cmake/modules/core/MakeTarget.cmake)
cmake//modules/core/MakeTarget.cmake:include(.hadouken/cmake/modules/core/detail/helper_functions.cmake)
cmake//modules/toolconf/CCache.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/toolconf/GCov.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/toolconf/LCov.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/toolconf/IncludeWhatYouUse.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/toolconf/ClangFormat.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/toolconf/GCovR.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/toolconf/GoogleTest.cmake:        TYPE STATIC SOURCES ${HDK_ROOT_PROJECT_SOURCE_DIR}/.hadouken/cmake/modules/toolconf/GoogleTest.cpp 
cmake//modules/toolconf/CppCheck.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/toolconf/GoogleBenchmark.cmake:        TYPE STATIC SOURCES ${HDK_ROOT_PROJECT_SOURCE_DIR}/.hadouken/cmake/modules/toolconf/GoogleBenchmark.cpp 
cmake//modules/toolconf/ClangTidy.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/toolconf/LLVMCov.cmake:include(.hadouken/cmake/modules/toolconf/detail/helper_functions.cmake)
cmake//modules/FeatureCheck.cmake:        if(NOT EXISTS "${HDK_ROOT_PROJECT_SOURCE_DIR}/.hadouken/cmake/modules/check/Check${arg}.cmake")
bash-5.2$ 
@ClausKlein
Copy link
Author

CMake Warning (dev) at chapter13/ex02_envfile_utility/CMakeLists.txt:17 (set):
  uninitialized variable 'CMAKE_MODULE_PATH'
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at chapter13/ex03_external_cmake_module/.hadouken/cmake/modules/core/MakeTarget.cmake:73 (if):
  uninitialized variable 'HDK_ROOT_PROJECT_NAME_UPPER'
Call Stack (most recent call first):
  chapter13/ex03_external_cmake_module/CMakeLists.txt:39 (make_target)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at chapter13/ex03_external_cmake_module/.hadouken/cmake/modules/core/MakeTarget.cmake:78 (if):
  uninitialized variable 'HDK_ROOT_PROJECT_NAME_UPPER'
Call Stack (most recent call first):
  chapter13/ex03_external_cmake_module/CMakeLists.txt:39 (make_target)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at chapter13/ex03_external_cmake_module/.hadouken/cmake/modules/core/MakeTarget.cmake:83 (if):
  uninitialized variable 'HDK_ROOT_PROJECT_NAME_UPPER'
Call Stack (most recent call first):
  chapter13/ex03_external_cmake_module/CMakeLists.txt:39 (make_target)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at chapter13/ex03_external_cmake_module/.hadouken/cmake/modules/core/MakeTarget.cmake:270 (if):
  uninitialized variable 'HDK_ROOT_PROJECT_NAME_UPPER'
Call Stack (most recent call first):
  chapter13/ex03_external_cmake_module/CMakeLists.txt:39 (make_target)
This warning is for project developers.  Use -Wno-dev to suppress it.

@ClausKlein ClausKlein changed the title TRY not used? TRY (Don't repeat yourself) not used? Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant