Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeoutError has nothing but setTimeout in the stack trace #1057

Open
filipw01 opened this issue Jan 17, 2025 · 2 comments
Open

TimeoutError has nothing but setTimeout in the stack trace #1057

filipw01 opened this issue Jan 17, 2025 · 2 comments

Comments

@filipw01
Copy link

It's hard to track down why timeout error happens because there's nothing in the stack trace

I think a solution might be here https://stackoverflow.com/questions/46528508/how-can-i-see-the-full-stack-trace-of-error-in-settimeout-with-a-promise

Moving TimeoutError creation outside of setTimeout and passing it to reject when it is needed

@filipw01
Copy link
Author

That's the stack trace I'm getting in sentry
Image

@sonnyp
Copy link
Member

sonnyp commented Jan 17, 2025

I noticed this as well but haven't had time to look into it. A minimal reproducer and a PR (ideally with test) would be helpful.

https://github.com/xmppjs/xmpp.js/blob/main/packages/events/lib/timeout.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants