Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intro to iOS] Week 3 - Please take a look at my app #1

Open
xuefanzhang opened this issue Oct 5, 2015 · 6 comments
Open

[Intro to iOS] Week 3 - Please take a look at my app #1

xuefanzhang opened this issue Oct 5, 2015 · 6 comments

Comments

@xuefanzhang
Copy link
Owner

/cc @codepathreview

@xuefanzhang xuefanzhang changed the title [Intro to iOS] Week 3 - Please take a look at my app at branch v1 [Intro to iOS] Week 3 - Please take a look at my app at branch v2 Oct 5, 2015
@xuefanzhang xuefanzhang changed the title [Intro to iOS] Week 3 - Please take a look at my app at branch v2 [Intro to iOS] Week 3 - Please take a look at my app Oct 5, 2015
@codepathreview
Copy link

master or v2?

@codepathreview
Copy link

master is more up to date, so I assume that branch

@codepathreview
Copy link

your walkthrough is kind of black, I think something went wrong with recording

@xuefanzhang
Copy link
Owner Author

so sorry!... I don't know why it did that. it should work now. A bit of an issue with automatically loading tweets. needed to pull to refresh :( And yes. All is on master. Thank you @codepathreview !!!

@codepathreview
Copy link

no worries, things happen. Thanks for the update!

@codepathreview
Copy link

👍 nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

  • You should declare all unnecessarily public properties as private for better encapsulation.
  • Nice work specifying the Auto Layout constraints.
  • Note that you should try handling the conditionally present retweet label in the cells. This is a situation where its not possible to specify the behavior that you want solely using Interface Builder.
  • You should try setting up the controls within the Tweet cells. It can sometimes be hard to have a clean design for embedded controls because it usually involves cumbersome plumbing. This is an instance where I think having the model handle the network action helps greatly simplify the implementation.
  • You should try implementing the post tweet insertion into the feed. In real MVC apps, the more polished experiences have to do a certain amount of local object management to make a fully seamless experience.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

-- dirk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants