Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intro to iOS] Week 4 - Please take a look at my twitter redux :) #2

Open
xuefanzhang opened this issue Oct 12, 2015 · 1 comment
Open

Comments

@xuefanzhang
Copy link
Owner

/cc @codepathreview

Thanks!

@codepathreview
Copy link

Nice work! We added this homework so that you'll have the experience building an app that's more similar in complexity to a production app. It's also useful to have practical experience building a container view controller, which is a more advanced topic. The optional account switching feature is interesting because you have to think about how TwitterClient is caching the access token to make sure it works correctly for multiple accounts. Displaying the account switching screen is implemented using custom view controller transitions.

A few notes after checking out the code:

  • I tried to run your app, but it wouldn't display the login sequence. Is master branch the right branch?
  • You should declare all unnecessarily public properties as private for better encapsulation.
  • Nice work specifying the Auto Layout constraints.
  • Nice work implementing the profile view controller so that it doesn't duplicate code in the timeline view controller.
  • Nice work encapsulating the properties of the custom cells that you added.
  • Nice work abstracting the hamburger controller so that it can be reused in other applications.
  • You should consider implementing the blurred table view header. There are several approaches here that are all valid. You can implement the header has a table header, a section header, or a cell. My preferred approach is to implement it as a table header, it's the easiest way to flow the image above the content. These detail touches are where you really learn the nooks and crannies of the framework.

Congratulations on finishing the final assignment! It's impressive to realize that in just four weeks, you've gone from building a simple tip calculator app to a polished MVC client.

-- dirk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants