Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of DefaultHasher #20

Open
ernieIzde8ski opened this issue Oct 28, 2024 · 0 comments
Open

Usage of DefaultHasher #20

ernieIzde8ski opened this issue Oct 28, 2024 · 0 comments

Comments

@ernieIzde8ski
Copy link

The OG genanki has a(n admittedly strange & somewhat broken) hash algorithm implemented from scratch, which, as far as I can tell, solves one issue: Python hashes are salted, and so are not consistent between runs. Similarly, genanki-rs uses DefaultHasher, which is not guaranteed to have a consistent implementation between compiler versions. This makes the implementation of guid_for in genank-rs unstable for repeated builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant