Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get passwords out of the logs #25

Open
yaronyg opened this issue Sep 14, 2017 · 0 comments
Open

Get passwords out of the logs #25

yaronyg opened this issue Sep 14, 2017 · 0 comments
Labels

Comments

@yaronyg
Copy link
Owner

yaronyg commented Sep 14, 2017

When we run commands as child processes we pass passwords in on the command lines we submit. In and of itself that isn't bad because these are temporary environments, there is no history or other record. But when we log the commands we include the full command line arguments which includes (wait for it) passwords! So we need to extend our command infrastructure to tell them which arguments have passwords as values and to not store them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant