Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multicall getNormalizedValueUsdc for optimization #57

Open
storming0x opened this issue Jul 9, 2021 · 3 comments
Open

Support multicall getNormalizedValueUsdc for optimization #57

storming0x opened this issue Jul 9, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P3 Fix if time

Comments

@storming0x
Copy link

It seems getNormalizedValueUsdc method is good for what yearn watch wants, it would be great if it supported batch calls (multicall), since potentially we will be calling this with all the want tokens we support which is a lot of promises and calls to web3 provider
@milkyklim milkyklim added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P3 Fix if time labels Sep 30, 2021
@milkyklim milkyklim changed the title [Feature Request]- support multicall getNormalizedValueUsdc for optimization Support multicall getNormalizedValueUsdc for optimization Sep 30, 2021
@pmdaly pmdaly mentioned this issue Jan 10, 2022
Closed
@x48115
Copy link
Contributor

x48115 commented Jan 19, 2022

@pmdaly can you reach out to me on telegram? @x48114

I believe we should tackle this bug with a different approach.
Rather than implementing multicall in the SDK (where the SDK does not use multicall at all) we should update the appropriate lens contract to give you the data you need:

https://github.com/yearn/yearn-lens/blob/master/contracts/Utilities/Helper/Helpers/PricesHelper.sol

The SDK utilizes lens contracts for data aggregation instead of multicall.

@pmdaly pmdaly mentioned this issue Jan 23, 2022
Merged
@karelianpie
Copy link
Contributor

@storming0x @pmdaly can this issue be closed?

@storming0x
Copy link
Author

https://github.com/yearn/yearn-lens/blob/master/contracts/Utilities/Helper/Helpers/PricesHelper.sol

Yes, will share w yearn watch team to follow on integration for SDK

@magic990619 magic990619 mentioned this issue Apr 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P3 Fix if time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@storming0x @milkyklim @karelianpie @x48115