Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value fallback for Settings #47

Open
Slayvin opened this issue May 23, 2019 · 1 comment
Open

Default value fallback for Settings #47

Slayvin opened this issue May 23, 2019 · 1 comment

Comments

@Slayvin
Copy link
Contributor

Slayvin commented May 23, 2019

The settings and settings groups are a great feature, but there is a problem when you have several language, and one is empty.
Let's say I want to use Settings to allow users to enter a GoogleMap api key and they have their sites in 3 languages.

Current result :
For now you have to fill the same value for the 3 languages in order to make it work. But for such setting, it makes no sense to have it translated, since the key is the same for all languages.

Expected result
If a settings value is empty/not set for a language, it should fall back to the value of the default language.

@naffiq naffiq assigned naffiq and unassigned naffiq May 27, 2019
@naffiq
Copy link
Contributor

naffiq commented May 27, 2019

@Slayvin good point, that sounds like a small but valuable fix. Will you have time to fix this behavior or shall we assign it to somebody else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants