Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade not compatible with rector 2 #784

Open
nesl247 opened this issue Jan 8, 2025 · 2 comments
Open

Upgrade not compatible with rector 2 #784

nesl247 opened this issue Jan 8, 2025 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nesl247
Copy link

nesl247 commented Jan 8, 2025

Rector 2.0 seems to have removed SetListInterface, so it is not possible to run the set list without downgrading.

The rules also don't work unfortunately:

         "System error: "The `Rector\Rector\AbstractScopeAwareRector` is removed, use `Rector\Rector\AbstractRector`
         instead, see upgrading guide https://github.com/rectorphp/rector-src/blob/main/UPGRADING.md#1-abstractscopeawarerector-is-removed-use-abstractrector-instead"
         Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line: 20```
@nikophil
Copy link
Member

nikophil commented Jan 9, 2025

Hi @nesl247

thanks for reporting. Yeah, I was expecting problems like this with Rector 2.

I don't know when I'll have time to work on this. Don't hesitate to provide a PR :)

@nikophil nikophil added enhancement New feature or request help wanted Extra attention is needed labels Jan 9, 2025
@nesl247
Copy link
Author

nesl247 commented Jan 10, 2025

I ended up doing it manually, so I don't have a need for it anymore unfortunately. If I find some time I'll try to tackle it, but it will probably be a while before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

No branches or pull requests

2 participants